[EuiInlineEdit] Types cleanup

- involves removing `children` from EuiInlineEditTitle/Text, but this is definitely more correct in terms of props/typing
elastic · Aug 1, 2023 · 95beab1 · 95beab1
1 parent 2fa936e
commit 95beab1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/components/inline_edit/inline_edit_form.tsx b/src/components/inline_edit/inline_edit_form.tsx
@@ -37,7 +37,10 @@ import { useGeneratedHtmlId } from '../../services/accessibility';
 import { euiInlineEditReadModeStyles } from './inline_edit_form.styles';
 
 // Props shared between the internal form component as well as consumer-facing components
-export type EuiInlineEditCommonProps = HTMLAttributes<HTMLDivElement> &
+export type EuiInlineEditCommonProps = Omit<
+  HTMLAttributes<HTMLDivElement>,
+  'children'
+> &
   CommonProps & {
     defaultValue: string;
     placeholder?: string;
@@ -90,10 +93,7 @@ export type EuiInlineEditCommonProps = HTMLAttributes<HTMLDivElement> &
   };
 
 // Internal-only props, passed by the consumer-facing components
-export type EuiInlineEditFormProps = Omit<
-  EuiInlineEditCommonProps,
-  'children'
-> & {
+export type EuiInlineEditFormProps = EuiInlineEditCommonProps & {
   /**
    * Form sizes
    */

diff --git a/src/components/inline_edit/inline_edit_text.tsx b/src/components/inline_edit/inline_edit_text.tsx
@@ -28,7 +28,6 @@ export type EuiInlineEditTextProps = EuiInlineEditCommonProps & {
 };
 
 export const EuiInlineEditText: FunctionComponent<EuiInlineEditTextProps> = ({
-  children,
   className,
   size = 'm',
   defaultValue,

diff --git a/src/components/inline_edit/inline_edit_title.tsx b/src/components/inline_edit/inline_edit_title.tsx
@@ -34,7 +34,6 @@ export type EuiInlineEditTitleProps = EuiInlineEditCommonProps & {
 };
 
 export const EuiInlineEditTitle: FunctionComponent<EuiInlineEditTitleProps> = ({
-  children,
   className,
   size = 'm',
   heading,