Skip to content

Commit

Permalink
Fixed typo and added custom scrollbar to tabs
Browse files Browse the repository at this point in the history
  • Loading branch information
cchaos committed Mar 20, 2018
1 parent f0798b4 commit 88c52ee
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/components/modal/__snapshots__/confirm_modal.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ exports[`renders EuiConfirmModal 1`] = `
class="euiModalFooter"
>
<button
class="euiButtonEmpty"
class="euiButtonEmpty euiButtonEmpty--primary"
data-test-subj="confirmModalCancelButton"
type="confirm"
type="button"
>
<span
class="euiButtonEmpty__content"
Expand Down
2 changes: 1 addition & 1 deletion src/components/modal/confirm_modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,6 @@ EuiConfirmModal.propTypes = {
type: PropTypes.oneOf(MODAL_TYPES),
};

EuiButtonEmpty.defaultProps = {
EuiConfirmModal.defaultProps = {
type: 'confirm',
};
9 changes: 9 additions & 0 deletions src/components/tabs/_tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
max-width: 100%;
overflow-x: auto;
overflow-y: hidden; // don't scroll vertically when scrolling horizontally
@include euiScrollBar;

// Changing height of scrollbar so it sits flush with border
&::-webkit-scrollbar {
height: 3px;
}

&.euiTabs--small {
.euiTab {
Expand Down Expand Up @@ -65,6 +71,9 @@

.euiTab__content {
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
transition: transform $euiAnimSpeedFast $euiAnimSlightBounce;
transform: translateY(0);
}
Expand Down

0 comments on commit 88c52ee

Please sign in to comment.