Fix lint issues & snapshots, re-enable clickOutsideDisables prop for …

…EuiFocusTrap
elastic · Sep 24, 2020 · 87eb56a · 87eb56a
1 parent ea36a18
commit 87eb56a
Show file tree

Hide file tree

Showing 10 changed files with 1,077 additions and 1,488 deletions.
diff --git a/src-docs/src/views/popover/popover.js b/src-docs/src/views/popover/popover.js
@@ -7,26 +7,26 @@ export default () => {
 
   return (
     <>
-      {
-        [0, 1, 2, 3, 4].map(idx => (
-          <div key={idx}>
-            <EuiPopover
-              anchorPosition="rightCenter"
-              ownFocus
-              button={(
-                <EuiButton data-idx={idx} iconType="arrowDown" iconSide="right" onClick={() => setOpenPopover(idx)}>
-                  Show popover
-                </EuiButton>
-              )}
-              isOpen={openPopover === idx}
-              closePopover={() => setOpenPopover(null)}>
-              <div>
-                Popover content that&rsquo;s wider than the default width
-              </div>
-            </EuiPopover>
-          </div>
-        ))
-      }
+      {[0, 1, 2, 3, 4].map(idx => (
+        <div key={idx}>
+          <EuiPopover
+            anchorPosition="rightCenter"
+            ownFocus
+            button={
+              <EuiButton
+                data-idx={idx}
+                iconType="arrowDown"
+                iconSide="right"
+                onClick={() => setOpenPopover(idx)}>
+                Show popover
+              </EuiButton>
+            }
+            isOpen={openPopover === idx}
+            closePopover={() => setOpenPopover(null)}>
+            <div>Popover content that&rsquo;s wider than the default width</div>
+          </EuiPopover>
+        </div>
+      ))}
     </>
   );
 };
diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -359,78 +359,69 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
                       panelPaddingSize="none"
                       withTitle={true}
                     >
-                      <EuiOutsideClickDetector
-                        isDisabled={true}
-                        onOutsideClick={[Function]}
+                      <div
+                        className="euiPopover euiPopover--anchorUpRight euiPopover--withTitle"
+                        onKeyDown={[Function]}
                       >
                         <div
-                          className="euiPopover euiPopover--anchorUpRight euiPopover--withTitle"
-                          onKeyDown={[Function]}
-                          onMouseDown={[Function]}
-                          onMouseUp={[Function]}
-                          onTouchEnd={[Function]}
-                          onTouchStart={[Function]}
+                          className="euiPopover__anchor"
                         >
-                          <div
-                            className="euiPopover__anchor"
+                          <EuiButtonEmpty
+                            color="text"
+                            data-test-subj="tablePaginationPopoverButton"
+                            iconSide="right"
+                            iconType="arrowDown"
+                            onClick={[Function]}
+                            size="xs"
                           >
-                            <EuiButtonEmpty
-                              color="text"
+                            <button
+                              className="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--xSmall"
                               data-test-subj="tablePaginationPopoverButton"
-                              iconSide="right"
-                              iconType="arrowDown"
                               onClick={[Function]}
-                              size="xs"
+                              type="button"
                             >
-                              <button
-                                className="euiButtonEmpty euiButtonEmpty--text euiButtonEmpty--xSmall"
-                                data-test-subj="tablePaginationPopoverButton"
-                                onClick={[Function]}
-                                type="button"
-                              >
-                                <EuiButtonContent
-                                  className="euiButtonEmpty__content"
-                                  iconSide="right"
-                                  iconType="arrowDown"
-                                  textProps={
-                                    Object {
-                                      "className": "euiButtonEmpty__text",
-                                    }
+                              <EuiButtonContent
+                                className="euiButtonEmpty__content"
+                                iconSide="right"
+                                iconType="arrowDown"
+                                textProps={
+                                  Object {
+                                    "className": "euiButtonEmpty__text",
                                   }
+                                }
+                              >
+                                <span
+                                  className="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
                                 >
-                                  <span
-                                    className="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
+                                  <EuiIcon
+                                    className="euiButtonContent__icon"
+                                    size="m"
+                                    type="arrowDown"
                                   >
-                                    <EuiIcon
+                                    <div
                                       className="euiButtonContent__icon"
+                                      data-euiicon-type="arrowDown"
                                       size="m"
-                                      type="arrowDown"
-                                    >
-                                      <div
-                                        className="euiButtonContent__icon"
-                                        data-euiicon-type="arrowDown"
-                                        size="m"
-                                      />
-                                    </EuiIcon>
-                                    <span
-                                      className="euiButtonEmpty__text"
+                                    />
+                                  </EuiIcon>
+                                  <span
+                                    className="euiButtonEmpty__text"
+                                  >
+                                    <EuiI18n
+                                      default="Rows per page"
+                                      token="euiTablePagination.rowsPerPage"
                                     >
-                                      <EuiI18n
-                                        default="Rows per page"
-                                        token="euiTablePagination.rowsPerPage"
-                                      >
-                                        Rows per page
-                                      </EuiI18n>
-                                      : 
-                                      2
-                                    </span>
+                                      Rows per page
+                                    </EuiI18n>
+                                    : 
+                                    2
                                   </span>
-                                </EuiButtonContent>
-                              </button>
-                            </EuiButtonEmpty>
-                          </div>
+                                </span>
+                              </EuiButtonContent>
+                            </button>
+                          </EuiButtonEmpty>
                         </div>
-                      </EuiOutsideClickDetector>
+                      </div>
                     </EuiPopover>
                   </div>
                 </EuiFlexItem>