Skip to content

Commit

Permalink
Improving EuiButtonEmpty focus state for color type text (#3135)
Browse files Browse the repository at this point in the history
* Adding darker background on focus state

* removing unecessary if statement

* Adding changelog

* Improving changelog
  • Loading branch information
elizabetdev authored Mar 20, 2020
1 parent 8e0daf9 commit 835a7cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Added `title` to headers of `EuiTable` in case of truncation ([#3094](https://github.com/elastic/eui/pull/3094))
- Added i18n to `EuiTableHeaderCell` ([#3094](https://github.com/elastic/eui/pull/3094))
- Added `number` and `string` to `size` type of `EuiImage` for setting custom sizes ([#3012](https://github.com/elastic/eui/pull/3012))
- Improved `EuiButtonEmpty` focus state when the `color` type is `text` ([#3135](https://github.com/elastic/eui/pull/3135))

**Bug Fixes**

Expand Down
6 changes: 1 addition & 5 deletions src/components/button/button_empty/_button_empty.scss
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,7 @@ $euiButtonEmptyTypes: (
}

&:focus {
@if ($name == 'text') {
background-color: $euiColorLightestShade;
} @else {
background-color: transparentize($color, .9);
}
background-color: transparentize($color, .9);
}

&:hover {
Expand Down

0 comments on commit 835a7cc

Please sign in to comment.