Skip to content

Commit

Permalink
Fixed typos in Changelog and other markdown files (#3305)
Browse files Browse the repository at this point in the history
  • Loading branch information
anishagg17 authored Apr 13, 2020
1 parent a83d879 commit 61ffb8a
Show file tree
Hide file tree
Showing 8 changed files with 46 additions and 46 deletions.
68 changes: 34 additions & 34 deletions CHANGELOG.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/services/popover/popover_positioning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ interface FindPopoverPositionResult {
* function return value will include an `arrow` param with position details
*
* @returns {FindPopoverPositionResult} absolute page coordinates for the
* popover, and the placements's relation to the anchor or undefined
* popover, and the placement's relation to the anchor or undefined
* there's no room.
*/
export function findPopoverPosition({
Expand Down Expand Up @@ -171,7 +171,7 @@ export function findPopoverPosition({
iterationAlignments.push(undefined, undefined); // discard desired alignment on cross-axis
}
} else {
// position is forced, if it conficts with the alignment then reset align to `null`
// position is forced, if it conflicts with the alignment then reset align to `null`
// e.g. original placement request for `downLeft` is moved to the `left` side, future calls
// will position and align `left`, and `leftLeft` is not a valid placement
if (
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Elastic Visual Regression

This module is a test suite used to test [EUI components](https://elastic.github.io/eui/#/). It is to be used to verify
that changes to code do not break thethe components visually by verifying current screenshots to a baseline taken
that changes to code do not break the components visually by verifying current screenshots to a baseline taken
previously.

## What EVR Does
Expand Down
2 changes: 1 addition & 1 deletion wiki/component-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export type EuiMegaMenuProps = {
};
```

For the default props we can just specify the enum values we want to use in the constructor and then use the maps to generate the classname for the component:
For the default props we can just specify the enum values we want to use in the constructor and then use the maps to generate the className for the component:

```tsx
export const EuiMegaMenu: FunctionComponent<EuiMegaMenuProps> = ({
Expand Down
2 changes: 1 addition & 1 deletion wiki/consuming.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ ReactDOM.render(

### "Module build failed" or "Module parse failed: Unexpected token" error

If you get an error when importing a React component, you might need to configure Webpack's `resolve.mainFields` to `['webpack', 'browser', 'main']` to import the components from `lib` intead of `src`. See the [Webpack docs](https://webpack.js.org/configuration/resolve/#resolve-mainfields) for more info.
If you get an error when importing a React component, you might need to configure Webpack's `resolve.mainFields` to `['webpack', 'browser', 'main']` to import the components from `lib` instead of `src`. See the [Webpack docs](https://webpack.js.org/configuration/resolve/#resolve-mainfields) for more info.

## Using the `test-env` build

Expand Down
2 changes: 1 addition & 1 deletion wiki/creating-components-yeoman.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ First, you'll be prompted for what kind of documentation to create:

| Choice | Description |
|--------------------|-----------------------------------------------------------|
| Component documention page | A new page for documenting a component |
| Component documentation page | A new page for documenting a component |
| Add example to an existing page | A new subsection of an existing documentation page |
| Sandbox | An empty document where you can do pretty much anything |

Expand Down
8 changes: 4 additions & 4 deletions wiki/creating-icons.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

EUI provides an ever-growing set of [icons][icons], but our set can be incomplete. If you find you need an icon that does not exist, create a new issue and tag it with the *icons* label. A designer from the EUI team will respond to discuss your needs.

If you are willing and able to design the icon yourself, this document descibes the guidelines for designing a new icon, cleaning up the SVG, and getting it added to EUI. While designers on the EUI team are available to assist, we greatly appreciate your contributions and pull requests.
If you are willing and able to design the icon yourself, this document describes the guidelines for designing a new icon, cleaning up the SVG, and getting it added to EUI. While designers on the EUI team are available to assist, we greatly appreciate your contributions and pull requests.

If you read through these guidelines or begin designing your icon and realize you're in too deep, then create an issue in this repo and request assistance. An EUI team member will reply and discuss options.

_**Note**: The `EuiIcon` component accepts external references to icon files, so you have the option to maintain the icon in your consuming applicaiton._
_**Note**: The `EuiIcon` component accepts external references to icon files, so you have the option to maintain the icon in your consuming application._

## Design the icon

Expand Down Expand Up @@ -35,7 +35,7 @@ This is where things get more opinionated. To maintain a cohesive, high quality
![Guides](https://user-images.githubusercontent.com/446285/63458958-5624f580-c419-11e9-89cf-45fa1b596329.png)

#### _For Sketch users_
_As a reference, you can downlaod and view the `icons.sketch` file via the **Sketch libraries** link atop the [EUI documentation site][docs] site. The Symbols page within this file contains artboards for the vast majority of EUI glyphs._
_As a reference, you can download and view the `icons.sketch` file via the **Sketch libraries** link atop the [EUI documentation site][docs] site. The Symbols page within this file contains artboards for the vast majority of EUI glyphs._

#### _For non-Sketch users_
_While we use Sketch to maintain our internal design library, you can use any design tool to produce the SVG file._
Expand Down Expand Up @@ -77,7 +77,7 @@ If everything looks good, then commit your changes, push up your branch, and ope
Opening a PR will notify the EUI team that your work is ready for review. Please include a screenshot in the description and reference the issue that your PR fixes.

### Ship it
Once youre PR is approved, you will be able to merge it and give yourself a well-deserved pat on the back. Finally, stay tuned for the next release of EUI at which point your icon will become available to the masses and appear on the EUI docs site.
Once your PR is approved, you will be able to merge it and give yourself a well-deserved pat on the back. Finally, stay tuned for the next release of EUI at which point your icon will become available to the masses and appear on the EUI docs site.

:trophy: _**Welcome to the Official EUI Icon Design Club**_ :beers:

Expand Down
4 changes: 2 additions & 2 deletions wiki/react-router.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const registerRouter = reactRouter => {
};

/**
* The logic for generating hrefs and onClick handlers from the `to` prop is largely borrowed from
* The logic for generating href and onClick handlers from the `to` prop is largely borrowed from
* https://github.com/ReactTraining/react-router/blob/v3/modules/Link.js.
*/
export const getRouterLinkProps = to => {
Expand Down Expand Up @@ -213,7 +213,7 @@ export const registerRouter = reactRouter => {
};

/**
* The logic for generating hrefs and onClick handlers from the `to` prop is largely borrowed from
* The logic for generating href and onClick handlers from the `to` prop is largely borrowed from
* https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/Link.js.
*/
export const getRouterLinkProps = to => {
Expand Down

0 comments on commit 61ffb8a

Please sign in to comment.