Skip to content

Commit

Permalink
changelog + remove docs section
Browse files Browse the repository at this point in the history
  • Loading branch information
cee-chen committed Mar 28, 2024
1 parent 8f860f1 commit 54ef8f8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 21 deletions.
10 changes: 10 additions & 0 deletions changelogs/upcoming/7632.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
**Breaking changes**

- The following props are no longer needed by `EuiBasicTable` or `EuiInMemoryTable` for responsive table behavior to work correctly, and can be removed:
- `isSelectable`
- `isExpandable`
- `hasActions`

**DOM changes**

- `EuiTableRow`s rendered by basic and memory tables now only render a `.euiTableRow-isSelectable` className if the selection checkbox is not disabled
21 changes: 0 additions & 21 deletions src-docs/src/views/tables/mobile/mobile_section.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Link } from 'react-router-dom';
import { GuideSectionTypes } from '../../../components';

import Table from './mobile';
import { EuiTextColor } from '../../../../../src/components/text';
import { EuiCode, EuiCodeBlock } from '../../../../../src/components/code';
const source = require('!!raw-loader!./mobile');
import { EuiTableRowCellMobileOptionsShape } from '../props/props';
Expand Down Expand Up @@ -51,26 +50,6 @@ export const section = {
Inversely, if you always want your table to render in a mobile-friendly
manner, pass <EuiCode>true</EuiCode>.
</p>
<p>
{/* TODO: This shouldn't be true by the end of the Emotion conversion */}
To make your table work responsively, please make sure you add the
following <EuiTextColor color="danger">additional</EuiTextColor> props
to the top level table component (<strong>EuiBasicTable</strong> or{' '}
<strong>EuiInMemoryTable</strong>):
</p>
<ul>
<li>
<EuiCode>isSelectable</EuiCode>: if the table has a single column of
checkboxes for selecting rows
</li>
<li>
<EuiCode>isExpandable</EuiCode>: if the table has rows that can expand
</li>
<li>
<EuiCode>hasActions</EuiCode>: if the table has a column for actions
which may/may not be hidden in hover
</li>
</ul>
<p>
The <EuiCode>mobileOptions</EuiCode> object can be passed to the{' '}
<strong>EuiTableRowCell</strong> directly or with each column item
Expand Down

0 comments on commit 54ef8f8

Please sign in to comment.