May 2022 deprecations (#5868)

* Removed `EuiDatePicker` accepting deprecated values for `popoverPosition` * Removed `partition` from Charts theme config - use `theme.partition` instead * Removed `data-gridcell-id` from EuiDataGrid cells - use separate `data-gridcell-column-id` & `data-gridcell-row-index` attributes instead * Changelog * Removed `noDivider` prop from `EuiFilterButton` * Removed `isSelected` and `isComplete` props from `EuiHorizontalStep` * Removed `isHollow` prop from `EuiStep` * Removed `display` prop from `EuiTabs`/`EuiTabbedContent` * Removed `descriptionDisplay` and `labelDisplay` props from `EuiSuggestItem` * Removed `.euiButton--subdued`/`$euiButtonTypes.subdued` * Removed `.eui-textOverflowWrap` * Removed `.euiYScrollWithShadows` * Removed automatic inclusion of tooltip plugin in custom `uiPlugins` passed to `EuiMarkdownEditor` * [PR feedback] EuiStepsHorizontalProps typing
elastic · May 4, 2022 · 170a8db · 170a8db
1 parent 89799ea
commit 170a8db
Show file tree

Hide file tree

Showing 45 changed files with 89 additions and 546 deletions.
diff --git a/src-docs/src/components/guide_section/guide_section_parts/guide_section_tabs.tsx b/src-docs/src/components/guide_section/guide_section_parts/guide_section_tabs.tsx
@@ -57,7 +57,7 @@ export const GuideSectionExampleTabs: FunctionComponent<GuideSectionExampleTabsP
 
   const renderTabs = () => {
     return (
-      <EuiTabs size="s" display="condensed">
+      <EuiTabs size="s" bottomBorder={false}>
         {tabs.map((tab, index) => {
           const {
             displayName,

diff --git a/src/components/datagrid/__snapshots__/data_grid.test.tsx.snap b/src/components/datagrid/__snapshots__/data_grid.test.tsx.snap
@@ -1138,7 +1138,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1170,7 +1169,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1202,7 +1200,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1234,7 +1231,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1266,7 +1262,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -1298,7 +1293,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -1602,7 +1596,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="leading"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1653,7 +1646,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="A"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1685,7 +1677,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="B"
               data-gridcell-column-index="2"
-              data-gridcell-id="2,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1717,7 +1708,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="trailing"
               data-gridcell-column-index="3"
-              data-gridcell-id="3,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -1768,7 +1758,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="leading"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1819,7 +1808,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="A"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1851,7 +1839,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="B"
               data-gridcell-column-index="2"
-              data-gridcell-id="2,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1883,7 +1870,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="trailing"
               data-gridcell-column-index="3"
-              data-gridcell-id="3,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -1934,7 +1920,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="leading"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -1985,7 +1970,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="A"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2017,7 +2001,6 @@ Array [
               class="euiDataGridRowCell"
               data-gridcell-column-id="B"
               data-gridcell-column-index="2"
-              data-gridcell-id="2,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2049,7 +2032,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn euiDataGridRowCell--controlColumn"
               data-gridcell-column-id="trailing"
               data-gridcell-column-index="3"
-              data-gridcell-id="3,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2333,7 +2315,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -2365,7 +2346,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -2397,7 +2377,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -2429,7 +2408,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -2461,7 +2439,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2493,7 +2470,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2756,7 +2732,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -2788,7 +2763,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,0"
               data-gridcell-row-index="0"
               data-gridcell-visible-row-index="0"
               data-test-subj="dataGridRowCell"
@@ -2820,7 +2794,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -2852,7 +2825,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,1"
               data-gridcell-row-index="1"
               data-gridcell-visible-row-index="1"
               data-test-subj="dataGridRowCell"
@@ -2884,7 +2856,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--firstColumn"
               data-gridcell-column-id="A"
               data-gridcell-column-index="0"
-              data-gridcell-id="0,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"
@@ -2916,7 +2887,6 @@ Array [
               class="euiDataGridRowCell euiDataGridRowCell--lastColumn"
               data-gridcell-column-id="B"
               data-gridcell-column-index="1"
-              data-gridcell-id="1,2"
               data-gridcell-row-index="2"
               data-gridcell-visible-row-index="2"
               data-test-subj="dataGridRowCell"

diff --git a/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap b/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap
@@ -104,7 +104,6 @@ exports[`EuiDataGridBody renders 1`] = `
       class="euiDataGridRowCell euiDataGridRowCell--boolean euiDataGridRowCell--firstColumn"
       data-gridcell-column-id="columnA"
       data-gridcell-column-index="0"
-      data-gridcell-id="0,0"
       data-gridcell-row-index="0"
       data-gridcell-visible-row-index="0"
       data-test-subj="dataGridRowCell"
@@ -138,7 +137,6 @@ exports[`EuiDataGridBody renders 1`] = `
       class="euiDataGridRowCell euiDataGridRowCell--string euiDataGridRowCell--lastColumn"
       data-gridcell-column-id="columnB"
       data-gridcell-column-index="1"
-      data-gridcell-id="1,0"
       data-gridcell-row-index="0"
       data-gridcell-visible-row-index="0"
       data-test-subj="dataGridRowCell"

diff --git a/src/components/datagrid/body/__snapshots__/data_grid_cell.test.tsx.snap b/src/components/datagrid/body/__snapshots__/data_grid_cell.test.tsx.snap
@@ -93,7 +93,6 @@ exports[`EuiDataGridCell renders 1`] = `
     className="euiDataGridRowCell"
     data-gridcell-column-id="someColumn"
     data-gridcell-column-index={0}
-    data-gridcell-id="0,0"
     data-gridcell-row-index={0}
     data-gridcell-visible-row-index={0}
     data-test-subj="dataGridRowCell"

diff --git a/src/components/datagrid/body/data_grid_cell.tsx b/src/components/datagrid/body/data_grid_cell.tsx
@@ -697,7 +697,6 @@ export class EuiDataGridCell extends Component<
         data-gridcell-column-index={this.props.colIndex} // Affected by column reordering
         data-gridcell-row-index={this.props.rowIndex} // Index from data, not affected by sorting or pagination
         data-gridcell-visible-row-index={this.props.visibleRowIndex} // Affected by sorting & pagination
-        data-gridcell-id={`${this.props.colIndex},${this.props.rowIndex}`} // TODO: Deprecate in favor of the above 4 data attrs
         onKeyDown={handleCellKeyDown}
         onFocus={this.onFocus}
         onMouseEnter={() => {

diff --git a/src/components/datagrid/data_grid.test.tsx b/src/components/datagrid/data_grid.test.tsx
@@ -545,7 +545,6 @@ describe('EuiDataGrid', () => {
             "className": "euiDataGridRowCell euiDataGridRowCell--firstColumn customClass",
             "data-gridcell-column-id": "A",
             "data-gridcell-column-index": 0,
-            "data-gridcell-id": "0,0",
             "data-gridcell-row-index": 0,
             "data-gridcell-visible-row-index": 0,
             "data-test-subj": "dataGridRowCell",
@@ -571,7 +570,6 @@ describe('EuiDataGrid', () => {
             "className": "euiDataGridRowCell euiDataGridRowCell--lastColumn customClass",
             "data-gridcell-column-id": "B",
             "data-gridcell-column-index": 1,
-            "data-gridcell-id": "1,0",
             "data-gridcell-row-index": 0,
             "data-gridcell-visible-row-index": 0,
             "data-test-subj": "dataGridRowCell",
@@ -597,7 +595,6 @@ describe('EuiDataGrid', () => {
             "className": "euiDataGridRowCell euiDataGridRowCell--firstColumn customClass",
             "data-gridcell-column-id": "A",
             "data-gridcell-column-index": 0,
-            "data-gridcell-id": "0,1",
             "data-gridcell-row-index": 1,
             "data-gridcell-visible-row-index": 1,
             "data-test-subj": "dataGridRowCell",
@@ -623,7 +620,6 @@ describe('EuiDataGrid', () => {
             "className": "euiDataGridRowCell euiDataGridRowCell--lastColumn customClass",
             "data-gridcell-column-id": "B",
             "data-gridcell-column-index": 1,
-            "data-gridcell-id": "1,1",
             "data-gridcell-row-index": 1,
             "data-gridcell-visible-row-index": 1,
             "data-test-subj": "dataGridRowCell",

diff --git a/src/components/date_picker/__snapshots__/date_picker.test.tsx.snap b/src/components/date_picker/__snapshots__/date_picker.test.tsx.snap
@@ -867,7 +867,7 @@ exports[`EuiDatePicker localization inherits locale from context 1`] = `
 </span>
 `;
 
-exports[`EuiDatePicker popoverPlacement top-end is rendered 1`] = `
+exports[`EuiDatePicker popoverPlacement upRight is rendered 1`] = `
 <EuiDatePicker
   adjustDateOnChange={true}
   aria-label="aria-label"
@@ -877,7 +877,7 @@ exports[`EuiDatePicker popoverPlacement top-end is rendered 1`] = `
   fullWidth={false}
   inputRef={[Function]}
   isLoading={false}
-  popoverPlacement="top-end"
+  popoverPlacement="upRight"
   shadow={true}
   shouldCloseOnSelect={true}
   showIcon={true}

diff --git a/src/components/date_picker/date_picker.test.tsx b/src/components/date_picker/date_picker.test.tsx
@@ -25,9 +25,9 @@ describe('EuiDatePicker', () => {
   });
 
   describe('popoverPlacement', () => {
-    test('top-end is rendered', () => {
+    test('upRight is rendered', () => {
       const component = mount(
-        <EuiDatePicker {...requiredProps} popoverPlacement="top-end" />
+        <EuiDatePicker {...requiredProps} popoverPlacement="upRight" />
       );
 
       expect(component).toMatchSnapshot();