Skip to content

Commit

Permalink
[EuiButtonGroup] pass a type of button when rendering a button for bu…
Browse files Browse the repository at this point in the history
…tton group button (#4368)

* [EuiButtonGroup] pass a type of button when rendering a button for button group button

* [EuiButtonGroup]: add some autodoc comments to new props

* [EuiButtonGroup]: add changes to change log

* [EuiButtonGroup]: PR feedback: change the type attribute to element; add type attribute to button content instead of in both button and button group option

* Move `type` back to EuiButtonGroupOption

And added a test for changing it

Co-authored-by: cchaos <[email protected]>
Co-authored-by: Caroline Horn <[email protected]>
  • Loading branch information
3 people authored Dec 9, 2020
1 parent b25de8c commit 07f2f32
Show file tree
Hide file tree
Showing 5 changed files with 78 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Fixed `inputRef` for `EuiCheckbox` ([#4298](https://github.com/elastic/eui/pull/4298))
- Limited the links allowed in `EuiMarkdownEditor` to http, https, or starting with a forward slash ([#4362](https://github.com/elastic/eui/pull/4362))
- Aligned components with an `href` prop to React's practice of disallowing `javascript:` protocols ([#4362](https://github.com/elastic/eui/pull/4362))
- Fixed form submit bug in `EuiButtonGroup` by adding an optional `type` prop for `EuiButtonGroupOption` ([#4368](https://github.com/elastic/eui/pull/4368))

**Theme: Amsterdam**

Expand Down
Loading

0 comments on commit 07f2f32

Please sign in to comment.