Skip to content

Commit

Permalink
[EuiFormRow] Respect child isDisabled (#5022)
Browse files Browse the repository at this point in the history
* respect isDisabled

* CL
  • Loading branch information
thompsongl authored Aug 12, 2021
1 parent 73b0276 commit 036a89c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Bug fixes**

- Fixed usage of `outsideClickCloses` prop of `EuiFlyout` ([#4986](https://github.com/elastic/eui/pull/4986))
- Fixed `EuiFormRow` ignoring `isDisabled` prop on the child element. ([#5022](https://github.com/elastic/eui/pull/5022))

## [`37.1.0`](https://github.com/elastic/eui/tree/v37.1.0)

Expand Down
4 changes: 2 additions & 2 deletions src/components/form/form_row/form_row.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@ export class EuiFormRow extends Component<EuiFormRowProps, EuiFormRowState> {
const child = Children.only(children);
const field = cloneElement(child, {
id,
// Allow the child's disabled prop to supercede the `isDisabled`
disabled: child.props.disabled ?? isDisabled,
// Allow the child's disabled or isDisabled prop to supercede the `isDisabled`
disabled: child.props.disabled ?? child.props.isDisabled ?? isDisabled,
onFocus: this.onFocus,
onBlur: this.onBlur,
...optionalProps,
Expand Down

0 comments on commit 036a89c

Please sign in to comment.