Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obj type for api generated files #460

Merged
merged 1 commit into from
Dec 12, 2023
Merged

remove obj type for api generated files #460

merged 1 commit into from
Dec 12, 2023

Conversation

pzl
Copy link
Member

@pzl pzl commented Dec 12, 2023

Change Summary

8.12 branch failing from diffs on these files. Looking to reconcile

21:29:07  :100644 100644 a5e712032f1cac5b9d7e03da8c02f0abc6584c02 0000000000000000000000000000000000000000 M	package/endpoint/data_stream/api/fields/fields.yml
21:29:07  :100644 100644 407721a6722d79f1581e911b9bfd7086f3ea6d8d 0000000000000000000000000000000000000000 M	schemas/v1/api/api.yaml

Release Target

8.12

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T15:59:52.830+0000

  • Duration: 7 min 23 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl pzl marked this pull request as ready for review December 12, 2023 16:09
@pzl pzl requested a review from a team as a code owner December 12, 2023 16:09
@pzl pzl merged commit 486ff84 into 8.12 Dec 12, 2023
@pzl pzl deleted the api-objtype branch December 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeypoon joeypoon joeypoon approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski is a code owner automatically assigned from elastic/security-defend-workflows

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzl @elasticmachine @joeypoon