Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional 8.11 custom documentation fields #450

Merged
merged 10 commits into from
Nov 14, 2023
Merged

additional 8.11 custom documentation fields #450

merged 10 commits into from
Nov 14, 2023

Conversation

ferullo
Copy link
Contributor

@ferullo ferullo commented Nov 13, 2023

Change Summary

Add custom documentation fields that were somehow missed in my previous PR #446

@ferullo ferullo requested a review from a team as a code owner November 13, 2023 18:38
ferullo
ferullo commented Nov 13, 2023
View reviewed changes
custom_documentation/src/endpoint/data_stream/api/windows/windows_api_credential_access.yaml
@@ -6,7 +6,7 @@ identification:
filter:
event.dataset: endpoint.events.api
event.module: endpoint
event.type: access
event.provider: ObjectCallback
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magermark I think this is the filtered keys we agreed on for API events and specifically the filter for credential access. Agreed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks correct. Double checked the code here: https://github.com/elastic/endpoint-dev/blob/main/Plugins/CredentialProtection/Lib/CredentialAccess.cpp#L658

magermark
magermark approved these changes Nov 13, 2023
View reviewed changes
custom_documentation/src/endpoint/data_stream/api/windows/windows_api_credential_access.yaml
@@ -6,7 +6,7 @@ identification:
filter:
event.dataset: endpoint.events.api
event.module: endpoint
event.type: access
event.provider: ObjectCallback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks correct. Double checked the code here: https://github.com/elastic/endpoint-dev/blob/main/Plugins/CredentialProtection/Lib/CredentialAccess.cpp#L658

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-13T18:39:26.746+0000

  • Duration: 59 min 59 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ferullo ferullo merged commit d21de02 into main Nov 14, 2023
@ferullo ferullo deleted the 8.11-custom-doc-2 branch November 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magermark magermark magermark approved these changes

@pzl pzl pzl approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski was automatically assigned from elastic/security-defend-workflows

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ferullo @elasticmachine @pzl @magermark @jdu2600