Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removes "required" field attribute #429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pzl
Copy link
Member

@pzl pzl commented Sep 25, 2023

Change Summary

package spec v3 does not allow for the property required in a mapping definition. This removes our instances of required (which seems to only pertain to @timestamp and ecs.version). Neither of these seem to be manually specified, but may be added as part of our reliance on the ECS build tools. An update to the tooling their may be needed to preserve the removal of this setting? Or a post-build step

This change is branched off of #428, so the changes there may also appear here, until that PR is merged

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 25, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T13:54:44.255+0000

  • Duration: 39 min 15 sec

Steps errors 1

Expand to view the steps failures

check for uncommitted build artifacts
  • Took 0 min 0 sec . View more details here
  • Description: git diff-index --exit-code HEAD --

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

but build tools will likely replace these until fixed
@pzl pzl force-pushed the specv3-req-fields branch from e16e349 to c569439 Compare September 29, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants