-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform schema v2 #270
Transform schema v2 #270
Conversation
It appears that Fleet may not yet support installing packages following the new spec. Here is the fleet issue tracker for that support: elastic/kibana#134321 |
I resolved the conflicts in this file by updating Let me know if it looks OK to you. I tested installing the package with this change with this PR: elastic/kibana#140046. We can merge if everything goes in on the Fleet side. |
@kevinlog looks good, verified the two extra fields ( will keep holding until kibana PR gets merged |
/test |
looks good! Can you just confirm that you stood this up and it installed correctly in a locally running stack? |
Yes, This worked correctly in a local stack. Tested three scenarios:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package endpoint - 8.10.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Change Summary
Updated the transform definitions to match the new Transform Spec
this involved mostly renaming files and translating from json to yaml
I tested these package changes against this PR: elastic/kibana#140046
You can see that the new transforms are installed below.
I added an Endpoint to make sure the data was still making it's way to the Endpoint list.
Release Target
next
Q/A
For mapping changes:
make
after making the schema changes, and committed all changesmetadata
change, I also updated both transform destination schemas to matchFor Transform changes:
Upgrade (from current json-based transform) & downgrade operate successfully