Replace recursive with loop in PackedValuesBlockHash #99992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
@nik9000 Please hold off the review. This doesn't pass all our tests. |
|
@nik9000 I think this is ready for review. Would you please take a look? Thank you! |
nik9000
approved these changes
Sep 28, 2023
| final BytesRef scratch = new BytesRef(); | ||
| final int[] loopedIndices = new int[groups.size()]; | ||
| final int[] valueCounts = new int[groups.size()]; | ||
| final int[] bytesStarts = new int[groups.size()]; |
There was a problem hiding this comment.
I think we'd be better of making an object for each group and have an array of those. But whatever works for you.
There was a problem hiding this comment.
I pushed f41c6e8, which is much cleaner.
|
@nik9000 Thank you for the review. |
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
This change replaces the recursion with a loop when packing and hashing multiple keys. While the recursive version is clever, it may not be as straightforward for future readers. Using a loop also helps us avoid StackOverflow when grouping by a large number of keys.
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
This change replaces the recursion with a loop when packing and hashing multiple keys. While the recursive version is clever, it may not be as straightforward for future readers. Using a loop also helps us avoid StackOverflow when grouping by a large number of keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the recursion with a loop when packing and hashing multiple keys. While the recursive version is clever, it may not be as straightforward for future readers. Using a loop also helps us avoid StackOverflow when grouping by a large number of keys.