Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supportsParallelCollection implementation for some aggs #99654

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Sep 19, 2023

After #98715, some of the aggregations that are disable for concurrent execution are eligible again. This PR enables them by removing the supportsParallelCollection implementation.

I run the AggregatorTestCase several times without errors.

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.11.0 labels Sep 19, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 61562f6 into elastic:main Sep 19, 2023
@iverase iverase deleted the supportsParallelCollection1 branch September 19, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.1.1 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants