ESQL: continue resolving attributes for Eval #99601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Hi @astefan, I've created a changelog YAML for you. |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
astefan
commented
Sep 15, 2023
Comment on lines
330
to
332
| if (ua.customMessage()) { | ||
| return ua; | ||
| } |
There was a problem hiding this comment.
In essence, skip this part (quickly returning from resolving an Attribute) and let eval have another chance at resolving expressions that use attributes from previous eval expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for attempting to resolve unresolved attributes was prematurely stopped when one attributes was deemed unresolvable disallowing chained evaluation expressions in the same
evalcommand. This small change makes the attributes resolution continue until all expressions are visited.Fixes #99576