Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Streamline Docker Compose docs #99371

Merged
merged 5 commits into from
Sep 11, 2023
Merged

[DOCS] Streamline Docker Compose docs #99371

merged 5 commits into from
Sep 11, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 8, 2023

Problem:
The Docker Compose docs are overly long. They currently display the entire length of related .env and docker-compose.yml files.

Solution:

  • Rewrite the Docker Compose docs as a procedural with ordered steps.
  • Provide download links for the .env and docker-compose.yml files rather than display them.
  • Move info about pulling and verifying Docker images into the Run Elasticsearch in Docker docs. These steps don't apply to the Docker Compose docs.

Closes https://github.com/elastic/platform-docs-team/issues/186
Depends on https://github.com/elastic/enterprise-search-pubs/pull/3788

@jrodewig jrodewig changed the title [DOCS] Streamline Docker Compose instructions [DOCS] Streamline Docker Compose docs Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Documentation preview:

@jrodewig jrodewig added >docs General docs changes :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Docs Meta label for docs team v8.10.1 v8.9.3 labels Sep 8, 2023
@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 8, 2023

@elasticsearchmachine run elasticsearch-ci/docs

@jrodewig jrodewig requested review from a team and removed request for a team September 8, 2023 17:02
@jrodewig jrodewig marked this pull request as ready for review September 8, 2023 17:04
@jrodewig jrodewig requested review from a team September 8, 2023 17:04
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Sep 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

Thanks @abdonpijpelink!

@jrodewig jrodewig merged commit 22371de into elastic:main Sep 11, 2023
@jrodewig jrodewig deleted the remove-long-docker-compose-examples branch September 11, 2023 15:05
@jrodewig
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10
8.9

Questions ?

Please refer to the Backport tool documentation

jrodewig added a commit that referenced this pull request Sep 11, 2023
**Problem:**

Other Elastic doc sets ([Beats](https://www.elastic.co/guide/en/beats/auditbeat/current/running-on-docker.html), [APM](https://www.elastic.co/guide/en/apm/guide/current/running-on-docker.html)) link to the [Verify the Elasticsearch Docker image signature](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/docker.html#docker-verify-signature) section of the Docker docs. This section was removed as part of #99371. When we bump to the next version, this will create broken links and break the docs build.

**Solution:**
Re-add the anchor so we don't create broken links or break the docs build.

This commit was added to the backports of #99371:

- #99429
- #99430
jrodewig added a commit to elastic/beats that referenced this pull request Sep 13, 2023
**Problem:**
The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371.

**Solution:**
Replace the x-ref with info about image verification.

Also:
- Removes unneeded `ifeval` tags
- Aligns notes for upcoming releases with those in the Elasticsearch docs
mergify bot pushed a commit to elastic/beats that referenced this pull request Sep 13, 2023
**Problem:**
The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371.

**Solution:**
Replace the x-ref with info about image verification.

Also:
- Removes unneeded `ifeval` tags
- Aligns notes for upcoming releases with those in the Elasticsearch docs

(cherry picked from commit e96b4ef)
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
**Problem:**
The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371.

**Solution:**
Replace the x-ref with info about image verification.

Also:
- Removes unneeded `ifeval` tags
- Aligns notes for upcoming releases with those in the Elasticsearch docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team v8.9.3 v8.10.1 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants