-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Streamline Docker Compose docs #99371
Merged
jrodewig
merged 5 commits into
elastic:main
from
jrodewig:remove-long-docker-compose-examples
Sep 11, 2023
Merged
[DOCS] Streamline Docker Compose docs #99371
jrodewig
merged 5 commits into
elastic:main
from
jrodewig:remove-long-docker-compose-examples
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
changed the title
[DOCS] Streamline Docker Compose instructions
[DOCS] Streamline Docker Compose docs
Sep 8, 2023
Documentation preview: |
jrodewig
added
>docs
General docs changes
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
Team:Docs
Meta label for docs team
v8.10.1
v8.9.3
labels
Sep 8, 2023
@elasticsearchmachine run elasticsearch-ci/docs |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-delivery (Team:Delivery) |
abdonpijpelink
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @abdonpijpelink! |
This was referenced Sep 11, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jrodewig
added a commit
that referenced
this pull request
Sep 11, 2023
**Problem:** Other Elastic doc sets ([Beats](https://www.elastic.co/guide/en/beats/auditbeat/current/running-on-docker.html), [APM](https://www.elastic.co/guide/en/apm/guide/current/running-on-docker.html)) link to the [Verify the Elasticsearch Docker image signature](https://www.elastic.co/guide/en/elasticsearch/reference/8.9/docker.html#docker-verify-signature) section of the Docker docs. This section was removed as part of #99371. When we bump to the next version, this will create broken links and break the docs build. **Solution:** Re-add the anchor so we don't create broken links or break the docs build. This commit was added to the backports of #99371: - #99429 - #99430
jrodewig
added a commit
that referenced
this pull request
Sep 11, 2023
jrodewig
added a commit
that referenced
this pull request
Sep 11, 2023
This was referenced Sep 11, 2023
jrodewig
added a commit
to elastic/beats
that referenced
this pull request
Sep 13, 2023
**Problem:** The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371. **Solution:** Replace the x-ref with info about image verification. Also: - Removes unneeded `ifeval` tags - Aligns notes for upcoming releases with those in the Elasticsearch docs
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Sep 13, 2023
**Problem:** The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371. **Solution:** Replace the x-ref with info about image verification. Also: - Removes unneeded `ifeval` tags - Aligns notes for upcoming releases with those in the Elasticsearch docs (cherry picked from commit e96b4ef)
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
**Problem:** The Beats Docker docs ([example](https://www.elastic.co/guide/en/beats/auditbeat/8.9/running-on-docker.html)) include an x-ref to the Elasticsearch docs for image verification. I recently removed this section as part of elastic/elasticsearch#99371. **Solution:** Replace the x-ref with info about image verification. Also: - Removes unneeded `ifeval` tags - Aligns notes for upcoming releases with those in the Elasticsearch docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
>docs
General docs changes
Team:Delivery
Meta label for Delivery team
Team:Docs
Meta label for docs team
v8.9.3
v8.10.1
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Docker Compose docs are overly long. They currently display the entire length of related
.env
anddocker-compose.yml
files.Solution:
.env
anddocker-compose.yml
files rather than display them.Closes https://github.com/elastic/platform-docs-team/issues/186
Depends on https://github.com/elastic/enterprise-search-pubs/pull/3788