async-search is_partial=true when any shard search fails or times out #98913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>bug
:Search/Search
|
Hi @quux00, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
quux00
force-pushed
the
async-search/fix-is_partial-local-search
branch
from
41e3327 to
f236c2e
Compare
|
When merged, be sure to inform the Kibana team, as they have a related change they need to make: elastic/kibana#164893 |
With the recent addition of per-cluster metadata to the `_clusters` section of the response for cross-cluster searches (see elastic#97731), the `is_partial` setting in the async-search response, now acts as a useful summary to end-users that search/aggs data from all shards is potentially incomplete (not all shards fully searched), which could be for one of 3 reasons: 1. at least one shard was not successfully searched (a PARTIAL search cluster state) 2. at least one cluster (marked as `skip_unavailable`=`true`) was unavailable (or all searches on all shards of that cluster failed), causing the cluster to be marked as SKIPPED 3. a search on at least one cluster timed out (`timed_out`=`true`, resulting in a PARTIAL cluster search status) This commit changes local-only (non-CCS) searches to behave consistently with cross-cluster searches, namely, if any search on any shard fails or if the search times out, the is_partial flag is set to true. Closes elastic#98725
quux00
force-pushed
the
async-search/fix-is_partial-local-search
branch
from
f236c2e to
4793600
Compare
|
Hey team, thanks for looking into this! The elastic/kibana#164893 issue is our team's (@elastic/kibana-data-discovery), and I just wanted to ask if we could get a heads up with a couple of days notice if you decide to merge this if possible? We have an idea of how we might handle it on the Kibana side, but we've been holding off implementing anything until we're sure this is going to be merged. |
This was referenced Sep 14, 2023
Closed
javanna
removed
the
:Search/Search
elasticsearchmachine
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent addition of per-cluster metadata to the
_clusterssection of the response for cross-cluster searches (see #97731), theis_partialsetting in the async-search response, now acts as a useful summary to end-users that search/aggs data from all shards is potentially incomplete (not all shards fully searched), which could be for one of 3 reasons:skip_unavailable=true) was unavailable (or all searches on all shards of that cluster failed), causing the cluster to be marked as SKIPPEDtimed_out=true, resulting in a PARTIAL cluster search status)This commit changes local-only (non-CCS) searches to behave consistently with cross-cluster searches, namely, if any search on any shard fails or if the search times out, the is_partial flag is set to true.
Closes #98725
Relates #55572