Esql warnings in tests #98699
Merged
Esql warnings in tests #98699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.11.0
needs:triage
not-napoleon
commented
Aug 21, 2023
| }), | ||
| new TestCaseSupplier("long-double overflow", () -> { | ||
| long base = 4339622345450989181L; // Not exactly representable as a double | ||
| long expected = 4339622345450989056L; |
There was a problem hiding this comment.
This is a pretty concerning behavior. For longs > 2^52, which are not exactly representable as doubles, x^1 != x. I'm not sure what we should do about this.
Honestly, I think there's a strong argument that pow should always return a double (which is what Java does), since most powers of large longs will overflow anyway.
not-napoleon
added
>non-issue
>test
elasticsearchmachine
added
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
nik9000
approved these changes
Aug 22, 2023
nik9000
approved these changes
Aug 22, 2023
| this.expectedWarnings = null; | ||
| } | ||
|
|
||
| public TestCase( |
There was a problem hiding this comment.
This maybe should be private just so it's normal to build it without the warnings and add, I guess.
There was a problem hiding this comment.
Like, I imagine it'd be nice if there was one "normal" way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ability to verify warnings in specific test cases. I added a few overflow tests to pow as an example. PR also includes other test, and wiring more pow examples into the parameterized framework.