Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the typo from my_app to my-app in the Put Search Application doc #96543

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Correct the typo from my_app to my-app in the Put Search Application doc #96543

merged 1 commit into from
Jun 5, 2023

Conversation

joecwu
Copy link
Contributor

@joecwu joecwu commented Jun 3, 2023

The term my-app is used in both the preceding and following text and sample code, so this typo my_app should be corrected.

@joecwu
fix typo, my-app -> my_app
c9312a9 
fix typo, `my-app` -> `my_app`
@cla-checker-service
Copy link

cla-checker-service bot commented Jun 3, 2023 •
edited
Loading

💚 CLA has been signed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.9.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 3, 2023
@abdonpijpelink abdonpijpelink added >docs General docs changes auto-backport-and-merge v8.8.1 and removed needs:triage Requires assignment of a team area label labels Jun 5, 2023
@abdonpijpelink abdonpijpelink self-assigned this Jun 5, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jun 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

abdonpijpelink
abdonpijpelink approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to these docs @joecwu . LGTM

@abdonpijpelink abdonpijpelink merged commit fe78e48 into elastic:main Jun 5, 2023
@abdonpijpelink abdonpijpelink mentioned this pull request Jun 5, 2023
Merged
abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Jun 5, 2023
@joecwu @abdonpijpelink
fix typo, my-app -> my_app (elastic#96543)
ea1d13d 
fix typo, `my-app` -> `my_app`
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.8

elasticsearchmachine pushed a commit that referenced this pull request Jun 5, 2023
@abdonpijpelink @joecwu
fix typo, my-app -> my_app (#96543) (#96549)
b3ed4bf 
fix typo, `my-app` -> `my_app`

Co-authored-by: Joe Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

Assignees

@abdonpijpelink abdonpijpelink

Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.8.1 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joecwu @elasticsearchmachine @abdonpijpelink