Do not copy index.default_pipeline and index.final_pipeline #96494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-campagna
added
:StorageEngine/Rollup
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @salvatore-campagna, I've created a changelog YAML for you. |
martijnvg
approved these changes
Jun 1, 2023
| @@ -584,12 +591,16 @@ private IndexMetadata.Builder copyIndexMetadata(IndexMetadata sourceIndexMetadat | |||
| // the same rules with resize apply | |||
| continue; | |||
| } | |||
| if (FORBIDDEN_SETTINGS.contains(key)) { | |||
| continue; | |||
| } | |||
| // Do not override settings that have already been set in the rollup index. | |||
There was a problem hiding this comment.
maybe update this comment too?
|
I forgot to push the yaml test... 🤔 |
💚 Backport successful
|
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jun 1, 2023
…96494) We need to skip copying the two settings, index.default_pipeline and index.final_pipeline, from the source index to the target index in order to avoid pipeline processing to be applied to the target (downsampled) index. Some pipeline scripts might fail due to the differences in mappings and settings between the downsampling source and target index.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 1, 2023
…96500) We need to skip copying the two settings, index.default_pipeline and index.final_pipeline, from the source index to the target index in order to avoid pipeline processing to be applied to the target (downsampled) index. Some pipeline scripts might fail due to the differences in mappings and settings between the downsampling source and target index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to skip copying the two settings, index.default_pipeline and index.final_pipeline, from the source index to the target index in order to avoid pipeline processing to be applied to the target (downsampled) index.
Some pipeline scripts might fail due to the differences in mappings and settings between the downsampling source and target index.
Resolves #96478