Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add analytics_collections to enterprise search usage in docs test #96385

Merged
merged 1 commit into from
May 26, 2023

Conversation

sloanelybutsurely
Copy link

adds the missing analytics_collections key to the response in usage.asciidoc. this was missed in #96063 because these tests are currently skipped in snapshot builds1.

fixes #96344

Footnotes

  1. https://github.com/elastic/elasticsearch/issues/95603#issuecomment-1535256381

@sloanelybutsurely sloanelybutsurely added >docs General docs changes >test Issues or PRs that are addressing/adding tests :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels May 26, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label May 26, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests!

@sloanelybutsurely
Copy link
Author

💚 All backports created successfully

Status Branch Result
8.8

Questions ?

Please refer to the Backport tool documentation

sloanelybutsurely pushed a commit to sloanelybutsurely/elasticsearch that referenced this pull request Jun 1, 2023
sloanelybutsurely pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :EnterpriseSearch/Application Enterprise Search Team:Docs Meta label for docs team Team:Enterprise Search Meta label for Enterprise Search team >test Issues or PRs that are addressing/adding tests v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DocsClientYamlTestSuiteIT test {yaml=reference/rest-api/usage/line_38} failing
3 participants