Fixes breaking change introduced in #95558. #95711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>bug
:Search Foundations/Mapping
|
Documentation preview: |
|
Pinging @elastic/es-search (Team:Search) |
elasticsearchmachine
added
the
external-contributor
quux00
removed
the
external-contributor
javanna
approved these changes
May 2, 2023
| *Note:* when specifying patterns (for `match`, `unmatch`, etc.) in an array, | ||
| {es} enforces that all values must be strings. However, for backwards | ||
| compatibility, {es} allows non-string values (such as numbers) for | ||
| single-valued match (and unmatch) fields. |
There was a problem hiding this comment.
I wonder if we should document this. My worry is that users may end up relying on this behaviour, while it is there only to prevent breaking templates. We could consider as a follow-up deprecating non string single values. What do you think?
There was a problem hiding this comment.
Yeah, I agree. Users should probably never use anything except strings, so probably good not to encourage the other usage. I'll remove it.
Match and unmatch fields in dynamic_templates (match, unmatch, path_match, path_unmatch) can either be single-valued or a list of values. If a list of values is provided, the values must all be strings. Numbers, boolean, other lists, etc. are not allowed and an error will be returned to the user in that case. However, previously (before elastic#95558) we allowed any JSON type for the match/unmatch fields (not just string), so changing that would be a breaking change. Thus, this commit no longer enforces string-only types for single-valued match/unmatch fields in dynamic_templates.
quux00
force-pushed
the
mapping/dyntemplates-with-arrays-2
branch
from
71fe7ef to
8e6a0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match and unmatch fields in dynamic_templates (match, unmatch, path_match, path_unmatch) can either be single-valued or a list of values. If a list of values is provided, the values must all be strings. Numbers, boolean, other lists, etc. are not allowed and an error will be returned to the user in that case.
However, previously (before #95558) we allowed any JSON type for the match/unmatch fields (not just string), so changing that would be a breaking change. Thus, this commit no longer enforces string-only types for single-valued match/unmatch fields in dynamic_templates.