Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping docs clarifications #94977

Conversation

DaveCTurner
Copy link
Contributor

Explains why you should remove cluster.initial_master_nodes, and rewords some of the other sections a little for (subjectively) improved readability.

Explains why you should remove `cluster.initial_master_nodes`, and
rewords some of the other sections a little for (subjectively) improved
readability.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.7.1 v8.8.0 labels Apr 3, 2023
@DaveCTurner DaveCTurner requested a review from kilfoyle April 3, 2023 08:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Apr 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Comment on lines -62 to -63
Like all node settings, it is also possible to specify the initial set of master
nodes on the command-line that is used to start Elasticsearch:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've removed most mention of this from elsewhere in the docs, I suspect because it only works for certain installation methods. No need to say it here either.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for fixing these up!

@DaveCTurner DaveCTurner merged commit f098940 into elastic:main Apr 3, 2023
@DaveCTurner DaveCTurner deleted the 2023-04-03-bootstrapping-docs-clarification branch April 3, 2023 13:43
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 3, 2023
Explains why you should remove `cluster.initial_master_nodes`, and
rewords some of the other sections a little for (subjectively) improved
readability.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.7

elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2023
Explains why you should remove `cluster.initial_master_nodes`, and
rewords some of the other sections a little for (subjectively) improved
readability.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 29, 2023
In elastic#94977 we tried to introduce a multi-paragraph admonition using a
list continuation (`+`) but this doesn't work. This commit fixes the
mistake using an admonition block instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.7.1 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants