Revert "Remove shortcutTotalHitCount optimization" #94876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 283f8ac.
javanna
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
approved these changes
Mar 29, 2023
javanna
deleted the
revert-89047-refactoring/remove_shortcut_total_hit_count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #89047
We have removed shortcut total hit count with #89047 and later noticed a couple of benchmark regressions. This PR reverts such change and reinstates the original logic for shortcut total hit count.
For the case where hits are collected, the total hit count is incremented as part of the collection in
TopScoreDocCollectorandTopFieldCollector, where Lucene does not support skipping the counting based onWeight#count. The previous change caused a regression specifically when collecting hits because we ended up removing our manual shortcut in favour of counting which causes overhead (the idea was rather to replace our own shortcutting mechanism with that from Lucene, which is though not extensive yet).