-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Expose authorization failure as transform health issue #94724
Merged
przemekwitek
merged 7 commits into
elastic:main
from
przemekwitek:permissions_when_dest_exists
Apr 5, 2023
Merged
[Transform] Expose authorization failure as transform health issue #94724
przemekwitek
merged 7 commits into
elastic:main
from
przemekwitek:permissions_when_dest_exists
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run elasticsearch-ci/docs |
przemekwitek
force-pushed
the
permissions_when_dest_exists
branch
6 times, most recently
from
March 29, 2023 11:18
499aaa2
to
8c0ebee
Compare
przemekwitek
force-pushed
the
permissions_when_dest_exists
branch
from
March 29, 2023 11:19
8c0ebee
to
f94580f
Compare
przemekwitek
changed the title
Expose authorization state in transform stats
[Transform] Expose authorization state as an object in transform stats
Mar 29, 2023
run elasticsearch-ci/packaging-tests-windows-sample |
Pinging @elastic/ml-core (Team:ML) |
Hi @przemekwitek, I've created a changelog YAML for you. |
przemekwitek
changed the title
[Transform] Expose authorization state as an object in transform stats
[Transform] Expose authorization failure as transform health issue
Mar 31, 2023
droberts195
reviewed
Mar 31, 2023
...re/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformHealthIssue.java
Outdated
Show resolved
Hide resolved
droberts195
reviewed
Mar 31, 2023
x-pack/plugin/transform/src/test/resources/rest-api-spec/schema/transform_health.schema.json
Show resolved
Hide resolved
droberts195
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
_stats
API with the information about the latest authorization failure, i.e. whether the authorization was successful or not, and if not, what was the error.This information is presented as a
TransformHealthIssue
underhealth
object.With this PR, the response of the
_stats
call will contain:if the last authorization was successful.
or
if the last authorization was unsuccessful.
Relates #93259