Mute connection fail log during test cluster stop #94523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a node connection failure is logged at the warn level every six failures. While stopping a test cluster this often fills the logs with many noisy logs. This is particularly true for large internal test clusters. This commit temporarily raises the NodeConnectionsService log to error during the cluster stop.
…ion_logs_in_tests
Tim-Brooks
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
I thought I would just open this to see what people think. These logs tend to not provide any valuable and there are sometimes a log of them. However, I also understand there might be some concerns around arbitrarily reducing the log level in this class for a period of time. |
idegtiarenko
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a node connection failure is logged at the warn level every
six failures. While stopping a test cluster this often fills the logs
with many noisy logs. This is particularly true for large internal test
clusters. This commit temporarily raises the NodeConnectionsService log
to error during the cluster stop.