Adding initial public and internal serverless scopes to Analytics-Geo REST handlers #94038
Conversation
masseyke
added
Team:Analytics
elasticsearchmachine
added
needs:triage
masseyke
added
Team:Analytics
elasticsearchmachine
added
needs:triage
thecoop
added
:Analytics/Geo
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
| @@ -19,6 +21,7 @@ | |||
|
|
|||
| import static org.elasticsearch.rest.RestRequest.Method.POST; | |||
|
|
|||
| @ServerlessScope(Scope.PUBLIC) | |||
There was a problem hiding this comment.
I wonder whether this should be a public api in server less.
I expect real downsampling usage to be via ilm or via the future data lifecycle mechanism in stateless/serverless.
So maybe make this an internal api? I suspect it easier to make an api public versus changing an api from public to internal?
There was a problem hiding this comment.
Yeah we'll likely never be able to take back a public one (after this actually goes live, that is). Do we even need it as internal? I assume ILM is hitting it through transport, not REST, right?
There was a problem hiding this comment.
Right, ILM is hitting the the api via transport. But maybe we may want this rest api accessible for debugging purposes. So let's make it internal?
#93607 added the ability to run Elasticsearch in "Serverless" mode, where access to REST endpoints could be restricted so that the full Elasticsearch API is not available (since a lot of it does not make sense in Servlerless). By default no endpoints are available, but they can be exposed with
ServerlessScopeannotations.This PR follows up on #93607 by adding PUBLIC and INTERNAL annotations to the rest handlers owned by the Analytics/Geo team. There are several rest endpoints still under discussion. This PR does not label those, so they remain unavailable in Serverless mode.