Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup in PRTS#doRecovery #93549

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Small cleanup in PRTS#doRecovery #93549

merged 3 commits into from
Feb 7, 2023

Conversation

DaveCTurner
Copy link
Contributor

Renames failureHandler to cleanupOnly and makes use of ActionListener#run where appropriate.

@DaveCTurner
Small cleanup in PRTS#doRecovery
f03254c 
Renames `failureHandler` to `cleanupOnly` and makes use of
`ActionListener#run` where appropriate.
@DaveCTurner DaveCTurner added :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >refactoring v8.7.0 labels Feb 7, 2023
@DaveCTurner DaveCTurner requested a review from pxsalehi February 7, 2023 10:40
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor Author

relates #93543 (comment)

@DaveCTurner
Copy link
Contributor Author

@elasticmachine update branch

@DaveCTurner
Copy link
Contributor Author

@elasticmachine update branch

pxsalehi
pxsalehi approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@pxsalehi pxsalehi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, David!

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 7, 2023
@elasticsearchmachine elasticsearchmachine merged commit 134f51b into elastic:main Feb 7, 2023
@DaveCTurner DaveCTurner deleted the 2023-02-07-doRecovery-rename-and-tidy branch February 7, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxsalehi pxsalehi pxsalehi approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >refactoring Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @elasticsearchmachine @pxsalehi @elasticmachine