Extract and dry more IO logic out of searchable snapshots module #93512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting more of the IO logic to the blob cache to make it reusable as well as dry it up a little. Small changes to the EOF exception message format in 2 cases in here that only remove redundant information.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Feb 6, 2023
x-pack/plugin/blob-cache/src/main/java/org/elasticsearch/blobcache/BlobCacheUtils.java
Outdated
Show resolved
Hide resolved
| @@ -20,4 +30,56 @@ public class BlobCacheUtils { | |||
| public static int toIntBytes(long l) { | |||
| return ByteSizeUnit.BYTES.toIntBytes(l); | |||
| } | |||
|
|
|||
| public static void throwEOF(long channelPos, long len, Object file) throws EOFException { | |||
There was a problem hiding this comment.
Let's add a unit test to ensure it effectively throws in case someone changes that behavior in the future
There was a problem hiding this comment.
How do you mean? Just a test that passes random inputs and verifies that it always throws? Why would anybody change that behavior?:) It's the only line in the method?
There was a problem hiding this comment.
Oh sorry I meant to have some basic test coverage on readSafe() that throws using this method. We have many Streams.read* and now BlobCacheUtils.readSafe() utility methods but we are lacking basic test coverage I think
|
Thanks Tanguy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting more of the IO logic to the blob cache to make it reusable as well as dry it up a little. Small changes to the EOF exception message format in 2 cases in here that only remove redundant information.