Clean up & streamline RestIndicesAction #93437
Merged
+117
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No need to wait for the get-settings call to return before sending the other requests. - No need to request cluster health at all, we can compute this locally from the cluster state. - No need to get the entire cluster state, we only need the metadata and routing table. - No need to put all the responses into an untyped list and then cast them out again.
DaveCTurner
added
>non-issue
:Data Management/Indices APIs
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
tlrx
approved these changes
Feb 2, 2023
| @@ -99,7 +99,7 @@ public RefCountingListener(int maxExceptions, ActionListener<Void> delegate) { | |||
| assert false : maxExceptions; | |||
| throw new IllegalArgumentException("maxExceptions must be positive"); | |||
| } | |||
| this.delegate = Objects.requireNonNull(delegate); | |||
| this.delegate = ActionListener.assertOnce(Objects.requireNonNull(delegate)); | |||
|
Guess who didn't even compile the tests before opening this? 🤡 |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 22, 2023
Similar to elastic#93437 we can run all the sub-requests in parallel.
DaveCTurner
added a commit
that referenced
this pull request
Oct 6, 2023
Similar to #93437 we can run all the sub-requests in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to wait for the get-settings call to return before sending the other requests.
No need to request cluster health at all, we can compute this locally from the cluster state.
No need to get the entire cluster state, we only need the metadata and routing table.
No need to put all the responses into an untyped list and then cast them out again.