Provide locally mounted secure settings implementation. #93392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @grcevski, I've created a changelog YAML for you. |
added 4 commits
February 1, 2023 13:58
…grcevski/elasticsearch into secure_settings/locally_mounted_secrets
williamrandolph
approved these changes
Feb 1, 2023
| * externally mounted local directory. It looks for the folder called 'secrets' | ||
| * under the config directory. All secure settings should be supplied in a single | ||
| * file called 'secrets.json' which sits inside the 'secrets' directory. | ||
| * <p> |
There was a problem hiding this comment.
Nit: it would be handy to have a sample settings.json (with dummy key-value pairs) in the javadoc.
| } | ||
|
|
||
| @Override | ||
| public InputStream getFile(String setting) throws GeneralSecurityException { |
There was a problem hiding this comment.
Would it be worth throwing an exception here? At least we should probably add a comment explaining that this implementation doesn't support files as setting value sources.
There was a problem hiding this comment.
Good catch, I'll actually add an implementation with ByteArrayInputStream, just like StatelessSecureSettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a different SecureSettings implementation which can fetch secrets from a locally mounted sub-directory under the Elasticsearch configuration directory.
Currently not used and in future should be extended to support reloading the secrets file if they are changed on disk.