Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransportGetTaskAction: Wait for the task asynchronously #93375

Merged
merged 25 commits into from
Feb 6, 2023
Merged

TransportGetTaskAction: Wait for the task asynchronously #93375

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a3c20f3
TransportGetTaskAction: Wait for the task asynchronously
arteam Jan 30, 2023
4633906
Remove unused method waitForTaskCompletion
arteam Jan 31, 2023
a8eba99
Don't fork waitedForCompletionListener
arteam Jan 31, 2023
8d79499
Remove unused imports
arteam Jan 31, 2023
5469643
Merge branch 'main' into transport-get-task-action-async
elasticmachine Jan 31, 2023
d80ffb0
Update server/src/main/java/org/elasticsearch/action/admin/cluster/no…
arteam Jan 31, 2023
d39b976
Inherit the warning from the previous task
arteam Feb 1, 2023
8d0b6a1
Merge remote-tracking branch 'origin/main' into transport-get-task-ac…
arteam Feb 1, 2023
0501970
Propagate failure if task has been cancelled due timeout
arteam Feb 1, 2023
1445188
Ignore reindex/30_search/Sorting deprecated wait_for_completion false
arteam Feb 1, 2023
c0f3883
Merge branch 'main' into transport-get-task-action-async
elasticmachine Feb 1, 2023
8b67372
Update docs/changelog/93375.yaml
arteam Feb 1, 2023
9bd2539
Update server/src/main/java/org/elasticsearch/action/admin/cluster/no…
arteam Feb 1, 2023
0978a52
Improve naming
arteam Feb 1, 2023
7db58ea
Add missed import
arteam Feb 2, 2023
395c808
Revert keeping warnings for getTask
arteam Feb 2, 2023
65be7c5
Merge remote-tracking branch 'origin/main' into transport-get-task-ac…
arteam Feb 2, 2023
9f6a7bb
Unmute blocking the thread pool
arteam Feb 2, 2023
55f347f
Revert "Unmute blocking the thread pool"
arteam Feb 2, 2023
9073672
Merge remote-tracking branch 'origin/main' into transport-get-task-ac…
arteam Feb 2, 2023
b9f62d1
Merge remote-tracking branch 'origin/main' into transport-get-task-ac…
arteam Feb 2, 2023
10e8958
Merge remote-tracking branch 'origin/main' into transport-get-task-ac…
arteam Feb 6, 2023
4c5a55f
Revert
DaveCTurner Feb 6, 2023
f50e739
Stop preserving response headers
DaveCTurner Feb 6, 2023
b3f415a
Remove bogus test comment
DaveCTurner Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/internalClusterTest/java/org/elasticsearch/action/admin/cluster/tasks/ListTasksIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void testWaitForCompletion() throws Exception {
}));

// briefly fill up the generic pool so that (a) we know the wait has started and (b) we know it's not blocking
// flushThreadPool(threadPool, ThreadPool.Names.GENERIC); // TODO it _is_ blocking right now!!, unmute this in #93375
flushThreadPool(threadPool, ThreadPool.Names.GENERIC);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm now that I look at this again, with these changes we're not using the GENERIC pool any more (indeed there's no forking at all when waiting for completion) so this line doesn't make sense. We can just drop this (and therefore inline flushThreadPool at its only other call-site).


assertFalse(listWaitFuture.isDone());
assertFalse(testActionFuture.isDone());
Expand Down