Ensure initial_master_nodes includes only master-eligible nodes #93212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine update branch |
This was referenced Jan 24, 2023
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 24, 2023
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 24, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 25, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring test clusters, ensure that the value for
initial_master_nodesincludes only master-eligible nodes. This will allow for testing multi-node clusters where some nodes do not have the master role.This implements a fix to
SettingsProviderresolution where referencing an existing setting would result in infinite recursion. We no longer try to resolve settings from a given settings provider when evaluating that settings provider to avoid any kind of recursion.