Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust range of allowed percentages of deletes in an index. #93188

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Adjust range of allowed percentages of deletes in an index. #93188

merged 2 commits into from
Jan 24, 2023

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Jan 24, 2023

Lucene 9.5 changed the allowed range and the default value for the allowed percentage of deletes in an index. It used to allow values in [20, 50] with a default of 33. It now allows values in [5, 50] with a default of 20.

See apache/lucene#11831.

@jpountz
Adjust range of allowed percentages of deletes in an index.
735631d 
Lucene 9.5 changed the allowed range and the default value for the allowed
percentage of deletes in an index. It used to allow values in [20, 50] with a
default of 33. It now allows values in [5, 50] with a default of 20.

See apache/lucene#11831.
@jpountz jpountz added >enhancement :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v8.7.0 labels Jan 24, 2023
@jpountz jpountz requested a review from javanna January 24, 2023 09:22
@elasticsearchmachine
Copy link
Collaborator

Hi @jpountz, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 24, 2023
@elasticsearchmachine elasticsearchmachine merged commit d086706 into elastic:main Jan 24, 2023
@jpountz jpountz deleted the adjust_deletes_pct_allowed_range branch January 24, 2023 10:04
@jpountz
Copy link
Contributor Author

jpountz commented Jan 24, 2023

Woops I had not realized that auto-merge would merge the PR even though there is no approval yet. @javanna I can revert if you think there is something that needs more discussions.

javanna
javanna reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0othing n0othing mentioned this pull request Jan 26, 2023
Closed
@gbanasiak gbanasiak mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna left review comments

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpountz @elasticsearchmachine @javanna