Add configurable operation listener for translog #92926
Conversation
This commit adds a listener that will be called when new operations are written to the translog writer.
Tim-Brooks
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @FunctionalInterface | ||
| public interface OperationListener { | ||
|
|
||
| void operationAdded(BytesReference data, long seqNo, Translog.Location location); |
There was a problem hiding this comment.
Are we expecting to add more operations to the listener?
Otherwise would it be better to use action listener with a record to hold all of the above arguments?
There was a problem hiding this comment.
I mean I'm not sure we should use an ActionListener as we do not have a failure condition here. I understand that we could use a Consumer<CustomRecord> but in that scenario we are still adding an abstraction (record vs. functional interface). So I guess I don't see the advantage to it.
yes definitely. Sorry this is for sure the main thing outstanding on this PR that I have been meaning todo. I'll add them later today. |
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
| OperationListener listener = (data, seqNo, location) -> { | ||
| seqNos.add(seqNo); | ||
| locations.add(location); | ||
| try (BytesStreamOutput output = new BytesStreamOutput()) { |
There was a problem hiding this comment.
Do we really need to copy the datum or we can just call datas.add(data)?
There was a problem hiding this comment.
The data in the listener is a ReleasableBytesReference from the Translog that will be released once the method returns. So yes. Obviously in tests it does not matter much, but it does matter for real usages.
I added documentation around the listener for this point.
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
This commit adds a listener that will be called when new operations are written to the translog writer.