-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve cluster alias for opened remote connections #92584
Resolve cluster alias for opened remote connections #92584
Conversation
Pinging @elastic/es-security (Team:Security) |
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build failure unrelated and tracked here: #92930 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticsearchmachine run elasticsearch-ci/part-2-fips |
#91724 introduced the ability to resolve the cluster alias, given a connection towards a remote cluster. This works for connections obtained via
RemoteConnectionManager::getConnection
. However, connections can also be initiated viaopenConnection
(e.g., inSniffConnectionStrategy
). This PR adds support to correctly resolve the cluster alias for such connections, by wrapping them in anInternalRemoteConnection
instance. This is necessary to support the new remote cluster security model.