Chunked encoding for CCR APIs #92526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CCR info and stats APIs can send fairly sizeable responses that scale as `O(#shards)`. This commit makes them chunked. Relates elastic#89838
DaveCTurner
added
>non-issue
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
| return channel -> client.execute( | ||
| CcrStatsAction.INSTANCE, | ||
| request, | ||
| new ThreadedActionListener<>( |
There was a problem hiding this comment.
Why do I still need a threaded listener with chunked encoding?
There was a problem hiding this comment.
The toXContent implementation collects all the shard responses into a map keyed by index up-front - I think that should be done elsewhere.
There was a problem hiding this comment.
On reflection this could reasonably be using the CCR pool, adjusted in a194c11.
| return channel -> client.execute( | ||
| FollowStatsAction.INSTANCE, | ||
| request, | ||
| new ThreadedActionListener<>( |
There was a problem hiding this comment.
Same here why does this need threading if it's chunked encoding?
| (builder, params) -> builder.startObject().field("auto_follow_stats", autoFollowStats, params).field("follow_stats") | ||
| ), | ||
| followStats.toXContentChunked(outerParams), | ||
| Iterators.single((builder, params) -> builder.endObject()) |
There was a problem hiding this comment.
NIT: I added org.elasticsearch.common.xcontent.ChunkedToXContentHelper#endObject for this.
original-brownbear
approved these changes
Dec 22, 2022
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCR info and stats APIs can send fairly sizeable responses that scale as
O(#shards). This commit makes them chunked.Relates #89838