Use smaller snapshot threadpool size on small nodes #92392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
v8.7.0
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
This should probably go to 8.6.0 not 8.6.1. |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Dec 16, 2022
While on larger data nodes (>= 750MB max heap), larger snapshot threadpool size improves snapshotting on high latency blob stores (elastic#90282), smaller instances can run into OOM issues and need a smaller snapshot threadpool size. Here, for these small nodes we revert back to the pool size pre-8.6. Closes elastic#92410
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2022
While on larger data nodes (>= 750MB max heap), larger snapshot threadpool size improves snapshotting on high latency blob stores (#90282), smaller instances can run into OOM issues and need a smaller snapshot threadpool size. Here, for these small nodes we revert back to the pool size pre-8.6. Closes #92410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While on larger data nodes (>= 750MB max heap), larger snapshot
threadpool size improves snapshotting on high latency blob stores
(#90282), smaller instances
can run into OOM issues and need a smaller snapshot threadpool size.
Here, for these small nodes we revert back to the pool size pre-8.6.
Closes #92410