Introduce Iterators#flatMap #92202
Merged
Introduce Iterators#flatMap #92202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various places that implement response chunking involving some kind of nested structure (e.g. a list of lists) need to call something like `flatMap`, and today this means they must must convert between iterators and streams to make use of `Stream#flatMap`. This is noisy and awkward, so with this commit we introduce a way to `flatMap` directly on iterators. Relates elastic#89838
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Dec 7, 2022
| } | ||
|
|
||
| @Override | ||
| public boolean hasNext() { | ||
| boolean hasNext = false; | ||
| while (index < iterators.length && (hasNext = iterators[index].hasNext()) == false) { | ||
| index++; |
There was a problem hiding this comment.
I find it weird to be changing state in hasNext() like this, I prefer to do all the moving in next() so that we're always pointing at a nonempty iterator until done.
original-brownbear
approved these changes
Dec 7, 2022
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various places that implement response chunking involving some kind of nested structure (e.g. a list of lists) need to call something like
flatMap, and today this means they must must convert between iterators and streams to make use ofStream#flatMap. This is noisy and awkward, so with this commit we introduce a way toflatMapdirectly on iterators.Relates #89838