Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] Fix Chunked APIs sending incorrect responses to HEAD requests (#92042) #92049

Merged

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.6:

…c#92042)

Response bodies must always be empty for HEAD requests.
Since the request encoder does not know that its dealing with a response
to a HEAD request we have to indicate this fact to it.
Also, needed to adjust the test http client to use the http-codec so it is able
to correlate what responses are meant for HEAD requests and will correctly read
responses for HEAD requests.
Without this change the added test reproduces the extra bytes and fails with an assert
about more than one response received.

closes elastic#92032
@original-brownbear original-brownbear added :Distributed Coordination/Network Http and internode communication implementations >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Dec 1, 2022
@elasticsearchmachine elasticsearchmachine merged commit 09f141b into elastic:8.6 Jan 3, 2023
@original-brownbear original-brownbear deleted the backport/8.6/pr-92042 branch January 3, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Distributed Coordination/Network Http and internode communication implementations Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants