Fix quadratic complexity in SnapshotStatus serialization #90795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot. This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map.
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Hi @original-brownbear, I've created a changelog YAML for you. |
|
@henningandersen I extracted this from an incoming PR that moves the API to chunked encoding. I made this a separate PR because I wonder if we should backport this to 8.5.x and 7.x, given how this API is causing issues here and there for Cloud ops? |
henningandersen
approved these changes
Oct 11, 2022
idegtiarenko
approved these changes
Oct 11, 2022
|
Thanks both! |
This was referenced Oct 11, 2022
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 11, 2022
The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot. This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 11, 2022
The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot. This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2022
…0803) The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot. This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2023
…) (#90802) * Fix quadratic complexity in SnapshotStatus serialization (#90795) The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot. This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map. * fix compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop here is obviously O(N^2) and it shows as taking multiple seconds to build the by-index map in x-content serialization for a 25k shards snapshot.
This makes the logic O(N) and fixes some potential issues with consistency around concurrent access by using a more appropriate access pattern to the field caching the by-index map.
Still not great but good enough with this change.
relates #77466