Make Step.StepKey a record #90755
Merged
Make Step.StepKey a record #90755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a random refactoring, but I found that master under heavy load gets surprisingly hot on the hashcode calculation in `StepKey` because that seems to not inline and actually sets up an `Object[]` array on every call when this thing is used for checking if there's work for an index. Instead of fixing the hashCode to run faster, lets just use a record to do this out of the box and save the code for equals and toString as well.
original-brownbear
added
>non-issue
:Data Management/ILM+SLM
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 10, 2022
Same reasoning as in elastic#90755, the hash code method in this thing is super hot and accounts for 10%+ of all allocations on master in the many shards snapshot benchmark -> lets use a record here instead to save some code and get a fast version out of the box.
original-brownbear
added a commit
that referenced
this pull request
Oct 10, 2022
Same reasoning as in #90755, the hash code method in this thing is super hot and accounts for 10%+ of all allocations on master in the many shards snapshot benchmark -> lets use a record here instead to save some code and get a fast version out of the box.
|
Thanks Joe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a random refactoring, but I found that master under heavy load gets surprisingly hot on the hashcode calculation in
StepKeybecause that seems to not inline and actually sets up anObject[]array on every call when this thing is used for checking if there's work for an index.Instead of fixing the hashCode to run faster, lets just use a record to do this out of the box and save the code for equals as well.
relates #77466