Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork building snapshot status response off of transport thread #90651

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Fork building snapshot status response off of transport thread #90651

merged 2 commits into from
Oct 5, 2022

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Oct 4, 2022 •
edited
Loading

This can take O(10s) for tens of thousands of shards, we have to fork it.
Currently, this one is the most common slow long on cloud ... (which isn't so great in a few dimensions :), on it)

relates #77466

@original-brownbear
Fork building snapshot status response off of transport thread
128b829 
This can take O(10s) for tens of thousands of shards, we have to fork
it.
@original-brownbear original-brownbear added >bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.5.0 v8.6.0 labels Oct 4, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 4, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @original-brownbear, I've created a changelog YAML for you.

tlrx
tlrx approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Tanguy!

@original-brownbear original-brownbear merged commit 0de2cdc into elastic:main Oct 5, 2022
@original-brownbear original-brownbear deleted the fork-snapshot-status branch October 5, 2022 09:26
@original-brownbear original-brownbear mentioned this pull request Oct 5, 2022
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 5, 2022
@original-brownbear
Fork building snapshot status response off of transport thread (elast…
78f29cc 
…ic#90651)

This can take O(10s) for tens of thousands of shards, we have to fork it.
relates elastic#77466
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.5

elasticsearchmachine pushed a commit that referenced this pull request Oct 5, 2022
@original-brownbear
Fork building snapshot status response off of transport thread (#90651)…
fef481c 
… (#90664)

This can take O(10s) for tens of thousands of shards, we have to fork it.
relates #77466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrx tlrx tlrx approved these changes

@henningandersen henningandersen Awaiting requested review from henningandersen

Assignees
No one assigned
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@original-brownbear @elasticsearchmachine @tlrx