Add easier configuration cache test support in build logic tests #88047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Jun 27, 2022
| def setup() { | ||
| projectDir = testProjectDir.root | ||
| settingsFile = testProjectDir.newFile('settings.gradle') | ||
| settingsFile << "rootProject.name = 'hello-world'\n" | ||
| buildFile = testProjectDir.newFile('build.gradle') | ||
| propertiesFile = testProjectDir.newFile('gradle.properties') | ||
| propertiesFile << | ||
| "org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME" | ||
| "org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME" |
There was a problem hiding this comment.
Some indents in this file seem have to have gone from 4 to 8.
pugnascotia
reviewed
Jun 27, 2022
...va/org/elasticsearch/gradle/internal/test/ConfigurationCacheCompatibleAwareGradleRunner.java
Outdated
Show resolved
Hide resolved
pugnascotia
reviewed
Jun 27, 2022
...va/org/elasticsearch/gradle/internal/test/ConfigurationCacheCompatibleAwareGradleRunner.java
Show resolved
Hide resolved
pugnascotia
approved these changes
Jun 27, 2022
breskeby
added
the
auto-merge-without-approval
pugnascotia
reviewed
Jun 27, 2022
| dataStreamAliasDiff != null | ||
| ? dataStreamAliasDiff.apply(((DataStreamMetadata) part).dataStreamAliases) | ||
| : ImmutableOpenMap.of() | ||
| dataStreamDiff.apply(((DataStreamMetadata) part).dataStreams), |
There was a problem hiding this comment.
This change looks unrelated?
breskeby
removed
the
auto-merge-without-approval
This is intended to help us getting closer to elastic#57918 by implicitly testing our build logic configuration-cache support. Plugin and Task tests can be marked as configuration cache compatible now and we will always run then with configuration cache enabled. By default, gradle will fail the build if configuration cache problems have been detected during build execution. That should be in general better then adding explicit tests for testing configuration cache compatibility per Test class
…ernal/test/ConfigurationCacheCompatibleAwareGradleRunner.java +1 Co-authored-by: Rory Hunter <[email protected]>
…ernal/test/ConfigurationCacheCompatibleAwareGradleRunner.java Co-authored-by: Rory Hunter <[email protected]>
breskeby
force-pushed
the
cleanup-build-logic-tests
branch
from
e71407c to
fa105ef
Compare
breskeby
added
the
auto-merge-without-approval
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 15, 2022
…stic#88047) This is intended to help us getting closer to elastic#57918 by implicitly testing our build logic configuration-cache support. Plugin and Task tests can be marked as configuration cache compatible now and we will always run then with configuration cache enabled. By default, gradle will fail the build if configuration cache problems have been detected during build execution. That should be in general better then adding explicit tests for testing configuration cache compatibility per Test class # Conflicts: # build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/AbstractGradleInternalPluginFuncTest.groovy # build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/LicenseHeadersPrecommitPluginFuncTest.groovy # build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy
breskeby
added a commit
that referenced
this pull request
Jul 15, 2022
) (#88569) This is intended to help us getting closer to #57918 by implicitly testing our build logic configuration-cache support. Plugin and Task tests can be marked as configuration cache compatible now and we will always run then with configuration cache enabled. By default, gradle will fail the build if configuration cache problems have been detected during build execution. That should be in general better then adding explicit tests for testing configuration cache compatibility per Test class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to help us getting closer to #57918 by implicitly testing our build logic
configuration-cache support. Plugin and Task tests can be marked as configuration cache compatible
now and we will always run then with configuration cache enabled.
By default, gradle will fail the build if configuration cache problems have been detected during
build execution. That should be in general better then adding explicit tests for testing configuration
cache compatibility per Test class