Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.3] Fix FollowIndexSecurityIT.testAutoFollowPatterns (#87853) #87915

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jun 22, 2022

The test FollowIndexSecurityIT.testAutoFollowPatterns sometimes
fails when verifying the monitoring documents about auto-follow
stats. I wasn't able to reproduce locally but I suspect that monitoring
collects auto-follow stats before they are updated. Instead it should
collect auto follow stats monitoring documents once indices are
effectively followed.

There are also some index / auto-follow pattern conflicts with other
tests in the same class, so this PR also changes that. In case this
fix is not enough, the full monitoring documents should appear in
test log to help further debugging.

Backport of #87853

The test FollowIndexSecurityIT.testAutoFollowPatterns sometimes 
fails when verifying the monitoring documents about auto-follow 
stats. I wasn't able to reproduce locally but I suspect that monitoring 
collects auto-follow stats before they are updated. Instead it should 
collect auto follow stats monitoring documents once indices are 
effectively followed.

There are also some index / auto-follow pattern conflicts with other 
tests in the same class, so this PR also changes that. In case this 
fix is not enough, the full monitoring documents should appear in 
test log to help further debugging.

Closes elastic#84888
@tlrx tlrx added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v8.3.1 labels Jun 22, 2022
@elasticsearchmachine elasticsearchmachine merged commit 0d8412a into elastic:8.3 Jun 22, 2022
@tlrx tlrx deleted the fix-84888-8.3 branch June 22, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants