Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apm_user role #87233

Closed
wants to merge 4 commits into from
Closed

Remove apm_user role #87233

wants to merge 4 commits into from

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 31, 2022

Meta issue: elastic/kibana#116760
The apm_user role was marked as deprecated in 7.13 and was supposed to be removed in 8.0.
All mentions of apm_user role was finally removed in elastic/kibana#132790 and this PR removes the actual role

The apm_user role was deprecated in 8.0 and is no longer needed since we have `viewer` and `editor` roles.
@elasticsearchmachine
Copy link
Collaborator

@sqren please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 31, 2022
@sorenlouv sorenlouv added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 31, 2022
@elasticmachine elasticmachine added the Team:Security Meta label for security team label May 31, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @sqren, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@sorenlouv
Copy link
Member Author

I added the >breaking label since this is technically a breaking change. OTOH the role was deprecated over a year ago, and the role was supposed to have been removed in 8.0. Finally removing it can be seen as an implementation detail.

@elasticsearchmachine
Copy link
Collaborator

Hi @sqren, I've updated the changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@ywangd
Copy link
Member

ywangd commented Jun 14, 2022

@sqren IIUC, the apm_user role was meant to be removed in 8.0, but we forgot to do so? If that's true, I think now it needs to go through the breaking change committee first for future removal in (possibly) 9.0.

@sorenlouv
Copy link
Member Author

sorenlouv commented Jun 14, 2022

@ywangd Yes we forgot to remove it in 8.0 (and there were no good alternatives available at the time). Now we are recommending users to use editor and viewer roles instead.
For this reason it's probably a better idea to remove it in 9.0 even though it's been deprecated since 7.13.

I'll update the PR to do that. Does it still need to go through the breaking change committee if we move the removal to 9.0?

@ywangd
Copy link
Member

ywangd commented Jun 14, 2022

Does it still need to go through the breaking change committee if we move the removal to 9.0?

Yes. We have a similar case and it needed to go through the committe. I'll tag you on the issue.

I'll update the PR to do that.

It's hard to do that now since we don't have a 9.0 branch yet.

@sorenlouv
Copy link
Member Author

Replaced by #87674

@sorenlouv sorenlouv closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants