Clean up request/response for get-cluster-settings #86347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today there are request and response objects for the get-cluster-settings action but the request is unused and the response is only used in the REST layer. This commit removes the unused request and renames the response to reflect that it's not a transport-layer response. It also tidies a few things up in this area, removing the unused `ActionResponse` superclass, making its fields final, and replacing the overly-general `RestBuilderListener` with a regular `RestToXContentListener` in the REST action. Relates elastic#82342 because to resolve that issue we will want to introduce transport-layer request/response classes, and the classes involved in this commit are in the way of that change.
DaveCTurner
added
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there are request and response objects for the
get-cluster-settings action but the request is unused and the response
is only used in the REST layer. This commit removes the unused request
and renames the response to reflect that it's not a transport-layer
response. It also tidies a few things up in this area, removing the
unused
ActionResponsesuperclass, making its fields final, andreplacing the overly-general
RestBuilderListenerwith a regularRestToXContentListenerin the REST action.Relates #82342 because to resolve that issue we will want to introduce
transport-layer request/response classes, and the classes involved in
this commit are in the way of that change.