Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use write block on archive indices #85102

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Mar 18, 2022

Ensure archive indices have a write block and the write block can't be removed.

Relates #81210

@ywelsch ywelsch added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.2.0 labels Mar 18, 2022
@ywelsch ywelsch requested a review from dnhatn March 18, 2022 14:12
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Mar 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)


import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.instanceOf;
import static org.hamcrest.Matchers.oneOf;

@ESIntegTestCase.ClusterScope(supportsDedicatedMasters = false, numClientNodes = 0, scope = ESIntegTestCase.Scope.TEST)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this code has just been extracted to a base class

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Yannick!

@ywelsch ywelsch merged commit 9fdd0dc into elastic:master Mar 18, 2022
@ywelsch
Copy link
Contributor Author

ywelsch commented Mar 18, 2022

Thank you Nhat!

@ywelsch ywelsch mentioned this pull request Mar 18, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants