Add delete privilege to kibana_system for APM #85085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
added
:Security/Authorization
elasticsearchmachine
added
the
external-contributor
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @axw, I've created a changelog YAML for you. |
simitt
reviewed
Mar 18, 2022
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
Outdated
Show resolved
Hide resolved
(To ensure we match future APM data streams as well.)
|
@elasticmachine run elasticsearch-ci/part-1 |
simitt
approved these changes
Mar 18, 2022
joshdover
approved these changes
Mar 18, 2022
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
Outdated
Show resolved
Hide resolved
|
Ping @elastic/kibana-security for awareness |
jportner
approved these changes
Mar 21, 2022
|
Thanks all! |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
This was referenced Mar 22, 2022
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
axw
added a commit
to axw/elasticsearch
that referenced
this pull request
Mar 22, 2022
* Add delete privilege to kibana_system for APM * Update docs/changelog/85085.yaml * Loosen APM data stream wildcards (To ensure we match future APM data streams as well.) * Fix trailing comma * Fix linting * Make data stream patterns more specific (cherry picked from commit e9f36d4)
axw
added a commit
that referenced
this pull request
Mar 22, 2022
* Add delete privilege to kibana_system for APM (#85085) * Add delete privilege to kibana_system for APM * Update docs/changelog/85085.yaml * Loosen APM data stream wildcards (To ensure we match future APM data streams as well.) * Fix trailing comma * Fix linting * Make data stream patterns more specific * Update docs/changelog/85199.yaml * Delete 85199.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
kibana_systemprivileges to allow deletion of all APM indices.This is a followup to #81811. Delete phases were added to all APM data stream ILM policies in 8.0.
Closes elastic/kibana#128014 elastic/apm-server#7568